Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to json5@1.0.1 #3466

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Upgrade to json5@1.0.1 #3466

merged 1 commit into from
Apr 21, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #3185

@codecov
Copy link

codecov bot commented Apr 21, 2018 •
edited
Loading

Codecov Report

Merging #3466 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3466   +/-   ##
=======================================
  Coverage   37.14%   37.14%           
=======================================
  Files         465      465           
  Lines       10320    10320           
  Branches      934      939    +5     
=======================================
  Hits         3833     3833           
+ Misses       5937     5911   -26     
- Partials      550      576   +26
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/layout/index.js 29.33% <0%> (ø) ⬆️
...-native/src/preview/components/OnDeviceUI/style.js 0% <0%> (ø) ⬆️
addons/info/src/components/makeTableComponent.js 67.46% <0%> (ø) ⬆️
addons/links/src/react/components/link.js 76.56% <0%> (ø) ⬆️
lib/core/src/client/preview/syncUrlWithStore.js 40.9% <0%> (ø) ⬆️
...ons/actions/src/lib/types/object/configureDepth.js 62.5% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
addons/knobs/src/components/types/Files.js 14.28% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReplacer.js 54.54% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb2ded...0f1f9d8. Read the comment docs.

@Hypnosphi Hypnosphi merged commit bca831e into master Apr 21, 2018
@Hypnosphi Hypnosphi deleted the upgrade-json5 branch April 21, 2018 20:17
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@alterx alterx Awaiting requested review from alterx alterx is a code owner

@danielduan danielduan Awaiting requested review from danielduan

@Gongreg Gongreg Awaiting requested review from Gongreg

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@rmevans9 rmevans9 Awaiting requested review from rmevans9

@shilman shilman Awaiting requested review from shilman shilman is a code owner

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal stijnkoopal is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees
No one assigned
Labels
cli core dependencies react-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hypnosphi @ndelangen @phated